Conversation
Author
|
Closing this in favour of IrreducibleOSS#16 to the upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains initial implementation of Blake3 G function gadget.
Essentially two inner gadgets are defined:
Add3, which computes addition of 3 u32 at once andXorRotateRight, which takes two u32 as input, computes their XOR and then rotates the XOR result. To check gadget's validity there is a test that uses standard Binius-style input with randomised data (viaunconstraintfunction) for the gadget and also in order to be sure that computations are valid, there is atest_vectortest that allows submitting some input and compare output produced by gadget and out-of-circuit implementation.